Re: slab corruption in test9 (NFS related?)

[Andrew Morton]

Linus Torvalds <torvalds@xxxxxxxx> wrote:
>
> 
> On Mon, 10 Nov 2003, Neil Brown wrote:
> >
> > An extra dput was introduced in nfsd_rename 20 months ago....
> > 
> > time to remove it.
> 
> Oh, you stand-up comedian you.
> 
> I'm just wondering how the hell this hasn't bit us seriously until now?  
> What's up?

Me too.

If the dentry was on the dentry_unused list then it would get a whacky
refcount and we would simply leak it.

It is only in the very rare case that the dentry gets freed up between the
two dput()s that the slab debugging will trip.

So probably, we've been leaking dentries as a result of rename activity by
NFS clients, but nobody noticed.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/