Re: [PATCH] Fix find busiest queue 2.6.0-test9

[Nick Piggin]

Andrew Morton wrote:

> Con Kolivas <kernel@xxxxxxxxxxx> wrote:
>
> > Hi
> >
> > I believe this is a simple typo / variable name mixup between rq_src and 
> > this_rq. So far all testing shows positive (if minor) improvements.
>
> Looks right to me.  I'll queue this up for the 2.6.1 deluge.

prev_cpu_load[i] is nr_running of cpu i last time this operation was
performed. Either it, or the current nr_running is taken, whichever
is lower.

I guess its done this way for cache benefits, but it was correct as
Ingo intended. For example, with Con's patch you can see
rq_src->prev_cpu_load[i] will only ever use the ith position in the array.

I wonder what improvements Con is seeing? If they are significant, change
prev_cpu_load to be an integer type and do a similar thing here.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/