Re: [BUG Missing define] 2.6.0-test 9-bk11: ALPHA: missing asm/mca.h

From: Herbert Xu
Date: Fri Nov 07 2003 - 21:41:33 EST


Thomas Steudten <alpha@xxxxxxxxxxxx> wrote:
>
> Andrew Morton wrote:
>
>> Thomas Steudten <alpha@xxxxxxxxxxxx> wrote:
>>
>>>This problem ist still there in -test9..
>>>
>>>In file included from drivers/net/3c509.c:77:
>>>include/linux/mca.h:15:21: asm/mca.h: No such file or directory
>
> Problem still there in -bk11. Who can fix this in the kernel
> source code?

I don't know. But here is a different approach which hides the
ifdef stuff in mca*.h.
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
Index: kernel-source-2.5/include/linux/mca-legacy.h
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/include/linux/mca-legacy.h,v
retrieving revision 1.1.1.3
retrieving revision 1.3
diff -u -r1.1.1.3 -r1.3
--- kernel-source-2.5/include/linux/mca-legacy.h 8 Oct 2003 19:24:51 -0000 1.1.1.3
+++ kernel-source-2.5/include/linux/mca-legacy.h 26 Oct 2003 04:50:38 -0000 1.3
@@ -7,6 +7,7 @@
#ifndef _LINUX_MCA_LEGACY_H
#define _LINUX_MCA_LEGACY_H

+#include <linux/config.h>
#include <linux/mca.h>

#warning "MCA legacy - please move your driver to the new sysfs api"
@@ -24,7 +25,7 @@
*/
#define MCA_NOTFOUND (-1)

-
+#ifdef CONFIG_MCA

/* Returns the slot of the first enabled adapter matching id. User can
* specify a starting slot beyond zero, to deal with detecting multiple
@@ -70,3 +71,4 @@
extern void mca_write_pos(int slot, int reg, unsigned char byte);

#endif
+#endif
Index: kernel-source-2.5/include/linux/mca.h
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/include/linux/mca.h,v
retrieving revision 1.4
retrieving revision 1.6
diff -u -r1.4 -r1.6
--- kernel-source-2.5/include/linux/mca.h 11 Oct 2003 06:29:27 -0000 1.4
+++ kernel-source-2.5/include/linux/mca.h 26 Oct 2003 04:50:38 -0000 1.6
@@ -6,6 +6,10 @@
#ifndef _LINUX_MCA_H
#define _LINUX_MCA_H

+#include <linux/config.h>
+
+#ifdef CONFIG_MCA
+
/* FIXME: This shouldn't happen, but we need everything that previously
* included mca.h to compile. Take it out later when the MCA #includes
* are sorted out */
@@ -149,4 +153,5 @@
}
#endif

+#endif /* CONFIG_MCA */
#endif /* _LINUX_MCA_H */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/