Re: [PATCH] amd76x_pm on 2.6.0-test9 cleanup

From: Pasi Savolainen
Date: Tue Nov 04 2003 - 15:23:01 EST


* Tony Lindgren <tony@xxxxxxxxxxx> [031104 21:24]:
> * john stultz <johnstul@xxxxxxxxxx> [031104 10:43]:
> > On Mon, 2003-11-03 at 16:22, Tony Lindgren wrote:
> > > After a year of not having access to my dual athlon box I finally ran
> > > apt-get dist-upgrade on it :)
> > >
> > > I also did some cleanup on the amd76x_pm to make the amd76x_pm to load as
> > > module, and to remove some unnecessary PCI code.
> >
> > I've received some reports that this patch causes time problems.
> >
> > Have those issues been looked into further, or addressed?
>
> I've heard of timing problems if it's compiled in, but supposedly they don't
> happen when loaded as module.

Not happening since 2.6.0-test9. Don't know what really fixed it, but
they're just not there anymore.

> Then the 2.4 version does not load if i2c-amd756 is loaded, but this may
> have been already fixed by this patch, I have not verified it yet though.

Most probably caused by the same thing that prevented it loading under
amd_k7_agp, that is indeed sorted out.

> I have problem where my S2460 goes into sleep for a while if compiled in,
> but this does not happen when loaded as module.

Could you have some AMD_76X -define left over? I skimmed through MP &
MPX AMD documents, but found nothing incriminating.
Could it be ACPI doing it's things with S -states? (it does check for
SMP, but does report S -states as supported). And if ACPI isn't
enabled, could you toggle it on, or vice-versa.


--
Psi -- <http://www.iki.fi/pasi.savolainen>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/