Re: minix fs corruption fix for 2.4

From: viro
Date: Mon Nov 03 2003 - 12:21:06 EST


On Mon, Nov 03, 2003 at 08:55:42AM -0800, Linus Torvalds wrote:
> I'd also prefer to do the test the other way around: test for CHRDEV and
> BLKDEV in inode.c the same way the other functions do. Something like the
> appended..
>
> Al, can you verify? I think this crept in when you did the block lookup
> cleanups. I also worry whether anybody else got the bug?
>
> Linus

Hmm... I would rather check for regular|directory|symlink explicitly -
note that FIFO and socket can have junk in i_data.

Looks like that fsckup had happened only in fs/minix - fs/sysv/itree.c
does it right.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/