Re: [PATCH] Altix I/O code cleanup

[Jes Sorensen]

>>>>> "Christoph" == Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:

>>  ASSERT_ALWAYS checks it, it may not be pretty but it does check
>> it.

Christoph> No, it's useless.  It's not different at all from just
Christoph> derefencing a NULL pointer - both get you an oops.

I haven't looked at the place right there, however if the intention is
to panic() on a failed kmalloc because the data structure is required
for a core service, then doing ASSERT_ALWAYS isn't that unreasonable.

Jes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/