Re: 2.6.0-test7: saa7134 breaks on gcc 2.95

[Ingo Oeser]

On Wednesday 15 October 2003 02:59, Andrew Morton wrote:
> Eyal Lebedinsky <eyal@xxxxxxxxxxxxxx> wrote:
> > This compiler does not like dangling comma in funcs, so this patch
> >  is needed. For:
> >
> >  #define dprintk(fmt, arg...)    if (core_debug) \
> >  	printk(KERN_DEBUG "%s/core: " fmt, dev->name, ## arg)
> >
> >  Lines like this:
> >
> >  	dprintk("hwinit1\n");
> >
> >  should be hacked like this:
> >
> >  	dprintk("hwinit1\n", "");
>
> I couldn't find a sane way.  Ended up doing this:
[splitting the printk]


GCC 2.95 doesn't like no space BEFORE AND AFTER the comma in the argument right
before the "## arg".

So just having a space there should work without splitting the printk. Not
compile tested, since I need to go now.

Regards

Ingo Oeser


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/