Re: [PATCH] Make pmdisk suspend more reliable

[Tony Lindgren]

Hi,

* Sam Ravnborg <sam@xxxxxxxxxxxx> [031012 11:07]:
> On Sun, Oct 12, 2003 at 09:18:28AM -0700, Tony Lindgren wrote:
> 
> >  extern int pmdisk_arch_suspend(int resume);
> > +extern int wakeup_bdflush(long nr_pages);
> 
> Prototypes in .c files is never a good idea.
> wakeup_bdflush is prototyped in include/linux/writeback.h

I guess you mean to #include <linux/writeback.h> instead of extern, or
did I misunderstand what you meant?

There may be more to the suspend image not getting to the disk besides
flushing, I'm now wondering if it works with IDE DMA enabled, but not
without DMA. I'll try to investigate it a bit further.

Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/