Re: [PATCH] page->flags corruption fix

From: Rik van Riel
Date: Sun Oct 12 2003 - 09:13:32 EST


On Sun, 12 Oct 2003, Hugh Dickins wrote:

> I agree on that too: I think Rik did it for atomicity throughout,
> to make the safety obvious; but in practice it was already safe.

Also to keep this fix future proof. Who knows whether
a super-optimised patch that masks just this particular
race condition will still be safe when XFS is merged ?

I really don't like keeping the code fragile and making
it easy to reintroduce bugs.

--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/