Re: [patch] SMP races in the timer code, timer-fix-2.6.0-test7-A0

From: Manfred Spraul
Date: Sat Oct 11 2003 - 11:57:02 EST


Ingo Molnar wrote:

On Sat, 11 Oct 2003, Ingo Molnar wrote:



since this would be the 8th word-sized field in struct timer_list,
making it a nice round structure size.



it's the 9th field in fact, due to timer->magic.


I found one problem: the same timer can run on multiple cpus at the same time.

timer on cpu 0. running on cpu 0.
add_timer on cpu 1. expires immediately. running on cpu 1.

Your mail arrived out of order - thus I don't know yet if the 9th field is a counter or a flag - a counter might work, but is quite ugly.

--
Manfred

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/