Re: [PATCH] laptop mode

[Pavel Machek]

Hi!

> > Right now laptopmode/aam is just a suspect. There are still 1-2 other
> > small patches against IDE which could be the reason.  We've dropped
> > laptopmode/aam for the time being to see if the folks seeing repeatable
> > corruption suddenly start behaving again.
> 
> aam patch is far more risky, it's a far more likely suspect. That patch
> never reall did go out of beta. Dropping laptop-mode and aam at the same
> time is bad engineering practice :).
> 
> laptop-mode cannot cause corruption that cannot show otherwise.

Well, if fireballs have data-corrupting that happens just after spinup
(for example), I can see how laptop-mode affects that. W/o
laptop-mode, disk is spinning all the time so sleep bugs can not
manifest themselves. You add laptop-mode, and...
								Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/