Re: [PATCH] net/sunrpc/clnt.c compile fix

[Trond Myklebust]

>>>>> " " == Paul Mundt <lethal@xxxxxxxxxxxx> writes:

     > Not sure if anyone has submitted this already, but as the
     > subject implies, net/sunrpc/clnt.c does not compile in either
     > stock test7 or in current BK:

Only if you do not also set CONFIG_SYSCTL.

     >   CC net/sunrpc/clnt.o net/sunrpc/clnt.c: In function
     >   `call_verify': net/sunrpc/clnt.c:965: structure has no member
     >   named `tk_pid' net/sunrpc/clnt.c:970: structure has no member
     >   named `tk_pid' net/sunrpc/clnt.c:976: structure has no member
     >   named `tk_pid' make[1]: *** [net/sunrpc/clnt.o] Error 1 make:
     >   *** [net/sunrpc/clnt.o] Error 2

     > This is due to the fact that tk_pid is protected by
     > RPC_DEBUG. Wrapping through dprintk() fixes this.

No... You are suppressing legitimate warning messages that inform the
user of a client/server mismatch!

Better then to remove the tk_pid from the warning messages...

Cheers
  Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/