Re: [PATCH] Fix mlockall for PROT_NONE mappings

[Linus Torvalds]

On 9 Oct 2003, Andi Kleen wrote:
> 
> That is exactly what the patch is doing.

No it's not.

What I'm asking for is a simple

	if (vma->vm_flags & VM_READ)
		make_pages_readable();

kind of thing. A couple of one-liners in the _callers_, not a horribly 
ugly change way down the stack.

Flags are ugly. Multi-value flags that have magic constants are worse. 
This patch deserves to die.

		Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/