Re: two sym53c8xx.o modules

[Matthew Wilcox]

On Thu, Oct 09, 2003 at 03:11:52PM +0200, Erik Mouw wrote:
> On Thu, Oct 09, 2003 at 01:38:57PM +0100, Matthew Wilcox wrote:
> > Is it really important to change this at this stage of 2.4?  For
> > reference, sym1 has already gone away in 2.6, so it'll be incovenient
> > for users no matter what you change.  Let's stick with the devil we know.
> 
> Yes it is. The _2 driver supports newer hardware (or better: can do
> faster speeds on newer hardware), while the old driver doesn't. The old
> driver, however, is more reliable in case of hardware errors. It's very
> nice to be able to change drivers on the fly without having to figure
> out the full path to the correct module.

No, that's not the point.  For people who are already using either driver,
there's no need to change anything between 2.4 and 2.6.  It's only the
foolish people who compile both as modules that have a problem.

If you change the sym2 driver to have a different module name, now people
have to change when they switch between 2.4 and 2.6.  That's bad.

We've had this problem all through 2.4 and it's never been an issue
until now.  I really think this is one problem which shouldn't be fixed.

> Hmm, just tested the _2 driver and now I remember why I hardly use it
> with flakey drives:
> 
>   root@dagobert:~ # scsiinfo -eXR /dev/sda 0 0 0 0 0 0 0 0 0 0 0 0 0 1
>   <4>sym0:4:0:extraneous data discarded.
>   <4>sym0:4:0:extraneous data discarded.
>   <4>sym0:4:0:extraneous data discarded.
>   <4>sym0:4:0:extraneous data discarded.
>   <4>sym0:4:0:extraneous data discarded.
>   Unable to store Read-Write Error Recovery Page 01h
>   18 00 00 00 18 00 00 00 70 00 05 00 00 00 00 18 
>   00 00 00 00 26 00 00 80 02 00 01 0a 00 00 00 00 
>   00 00 00 00 00 01 00 00 00 00 00 00 00 00 00 00 
> 
> I haven't figured out what it could be yet, scsiinfo works perfectly
> well with the old sym58xxx driver (and the aic7xxx driver, FWIW).

It works perfectly fine with the drives I have access to under 2.6 ...

> Anyway, here's a patch to rename sym53c8xx_2/sym53c8xx.o to
> sym53c8xx_2/sym53c8xx_2.o. It's against 2.4.22, but should apply to all
> 2.4 kernels.

Please don't apply this patch.

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/