Re: [pm] Re: JFFS2 swsusp / signal cleanup.

[Pavel Machek]

Hi!

> Do you need locking for recalc_sigpending()?

Hmm, seems so; btw your patch seems to miss it too:

> @@ -104,6 +105,13 @@
>                       schedule();
>               }
>
> +             if (current->flags & PF_FREEZE) {
> +                     refrigerator(0);        /* When this loses its
> stupid flush_signals()
> +                                                and starts just
> calling recalc_sigpending(),
> +                                                you can remove the
> following: */
> +                     recalc_sigpending();
> +             }
> +
>               cond_resched();
>
>               /* Put_super will send a SIGKILL and then wait on the
> sem.

I'll test it and send updated patch.
								Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/