Re: [PATCH] cleanup of compat_ioctl functions

From: Pavel Machek
Date: Wed Oct 08 2003 - 14:31:01 EST


Hi!

> This is my reworked patch for cleaning up compat_ioctl, with the main
> purpose of making it usable for s390. Every single change here should
> be trivial, but there are a lot of them.

Looks good to me. [I just scanned it...]

Perhaps it compat_ptr_u32(arg), that returns (u32 __user *) should be
invented? [Well, its used only 3 times, so maybe this is bad idea].

Also __u32 should not be used here, it looks too ugly and u32 is
okay. Same for __u16 and __u64. Its simple search&replace, and as you
are doing lots of changes, anyway....
Pavel

--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/