Re: 2.6.0-test6: more __init bugs

[Robert T. Johnson]

On Tue, 2003-09-30 at 02:42, Corey Minyard wrote:
> This is not actually a bug, but it may be bad style (and thus could lead 
> to a bug).  It is possible that something that uses IPMI can do some 
> IPMI things before IPMI is initialized.  This can only happen during 
> initialization, though.  Thus the check; once IPMI is initialized the 
> function will never be called.
> 
> What's the opinion on this?  Should I just force IPMI users to 
> initialize after IPMI?

Thanks for looking at it.  Would it be reasonable to fail if a client
tries to use the ipmi interface before it is initialized?  That would be
a simple change, e.g.:

if (!initialized)
       return -ENODEV;

Best,
Rob


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/