Re: 2.6.0-test6: a few __init bugs

[Robert T. Johnson]

On Tue, 2003-09-30 at 12:11, Greg KH wrote:
> Hm, care to send in a patch that adds a comment to that __init call so
> that others don't make the same mistake in a year or so?

Here's the patch you requested, but I recommend against applying it
since it's the sort of comment that can easily become wrong, leading to
missed bugs in future kernels.  Thanks again for your help.

Best,
Rob

--- drivers/pci/quirks.c.orig	Tue Sep 30 14:17:40 2003
+++ drivers/pci/quirks.c	Tue Sep 30 14:16:57 2003
@@ -869,6 +869,9 @@
 
 void pci_fixup_device(int pass, struct pci_dev *dev)
 {
+	/* Note: Many of the hooks in pci_fixups are declared __init
+           or __devinit, but this is ok because, currently, none of
+           the devices with quirk hooks are hot-pluggable. */
 	pci_do_fixups(dev, pass, pcibios_fixups);
 	pci_do_fixups(dev, pass, pci_fixups);
 }


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/