Re: [PATCH] Mutilated form of Andi Kleen's AMD prefetch errata patch

From: H. Peter Anvin
Date: Tue Sep 30 2003 - 15:10:45 EST


Followup to: <p73pthiyu0e.fsf@xxxxxxxxxxxxxxxx>
By author: Andi Kleen <ak@xxxxxxx>
In newsgroup: linux.dev.kernel
>
> I implemented it for long mode on x86-64.
>
> It has to be done before the vesafb is initialized too, otherwise
> you cannot see the error message.
>
> You could copy the code from arch/x86_64/boot/setup.S
> (starting with /* check for long mode. */) and change it to
> check for the CPUID bits you want. x86-64 checks a basic collection
> that has been determined to be the base set of x86-64 supporting CPUs.
> But it could be less or more.
>

Do it in boot/setup.S so that you can still issue a message via the
BIOS. However, don't forget you might need bug fixes/workarounds like
the P6 SEP in there, too. From that perspective it would be nice to
have something that can be written in C. Recent binutils actually
allow gcc-generated .s-files to be assembled for a 16-bit environment
(with lots of overrides.)

-hpa
--
<hpa@xxxxxxxxxxxxx> at work, <hpa@xxxxxxxxx> in private!
If you send me mail in HTML format I will assume it's spam.
"Unix gives you enough rope to shoot yourself in the foot."
Architectures needed: ia64 m68k mips64 ppc ppc64 s390 s390x sh v850 x86-64
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/