Re: [PATCH] ULL fixes for qlogicfc

[Dave Jones]

On Mon, Sep 29, 2003 at 01:23:29PM -0400, Jeff Garzik wrote:
 > On Mon, Sep 29, 2003 at 06:04:34PM +0100, davej@xxxxxxxxxx wrote:
 > > diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/scsi/qlogicfc.c linux-2.5/drivers/scsi/qlogicfc.c
 > > --- bk-linus/drivers/scsi/qlogicfc.c	2003-09-08 00:47:00.000000000 +0100
 > > +++ linux-2.5/drivers/scsi/qlogicfc.c	2003-09-08 01:30:56.000000000 +0100
 > > @@ -718,8 +718,8 @@ int isp2x00_detect(Scsi_Host_Template * 
 > >  				continue;
 > >  
 > >  			/* Try to configure DMA attributes. */
 > > -			if (pci_set_dma_mask(pdev, (u64) 0xffffffffffffffff) &&
 > > -			    pci_set_dma_mask(pdev, (u64) 0xffffffff))
 > > +			if (pci_set_dma_mask(pdev, 0xffffffffffffffffULL) &&
 > > +			    pci_set_dma_mask(pdev, 0xffffffffULL))
 > >  					continue;
 > 
 > Looks great.
 > 
 > I wonder if you are motivated to create similar pci_set_dma_mask()
 > cleanups for other drivers?  ;-)

Yeah, I'm on it.  I have some patches already, will do another
bombing run later tonight.

		Dave

-- 
 Dave Jones     http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/