Re: [PATCH] Many groups patch.

From: Linus Torvalds
Date: Mon Sep 29 2003 - 12:31:29 EST



On Mon, 29 Sep 2003, Rusty Russell wrote:
>
> This version drops the internal groups array (it's so often shared
> that it's not worth it, and the logic becomes a bit neater), and does
> vmalloc fallback in case someone has massive number of groups.

Why?

kmalloc() works fine. Anybody who needs 200 groups may be sane, but
anybody who needs more than fits in a kmalloc() is definitely so far out
that there is no point.

The vmalloc space is limited, and the code just gets uglier.

Have you been looking at glibc sources lately, or why do you believe that
we should encourage insane usage?

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/