Re: [pm] Make software resume be called at resume

[Patrick Mochel]

> [Yes, software_suspend needs to return int and do some error
> handling. But not today, and this is better than random bit flips.]

Random bit flips? I have no idea what you're talking about. 

> --- clean/kernel/power/swsusp.c	2003-09-28 22:06:45.000000000 +0200
> +++ linux/kernel/power/swsusp.c	2003-09-29 00:19:37.000000000 +0200
> @@ -5,7 +5,10 @@
>   * machine suspend feature using pretty near only high-level routines
>   *
>   * Copyright (C) 1998-2001 Gabor Kuti <seasons@xxxxxxxxx>
> - * Copyright (C) 1998,2001,2002 Pavel Machek <pavel@xxxxxxx>
> + * Copyright (C) 1998,2001-2003 Pavel Machek <pavel@xxxxxxx>
> + * Copyright (C) 2003 Patrick Mochel <mochel@xxxxxxxx>

Please remove this. I want as little correlation between my name and 
swsusp as possible. 

>  static void do_software_suspend(void)
>  {
> -	arch_prepare_suspend();
> +	if (arch_prepare_suspend())
> +		panic("Architecture failed to prepare\n");

For crying out loud, why? WTF is wrong with:


		printk("Architecture failed to prepare\n");
		return;

? Why do that to your users? 



	Pat

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/