Re: [PATCH 8/8] Add BTN_TOUCH to Synaptics driver. Update mousedev.

From: Dmitry Torokhov
Date: Fri Sep 26 2003 - 21:03:24 EST


On Friday 26 September 2003 02:54 am, Vojtech Pavlik wrote:
> On Fri, Sep 26, 2003 at 02:24:53AM -0500, Dmitry Torokhov wrote:
> > On Thursday 25 September 2003 05:30 pm, Vojtech Pavlik wrote:
> > > > BTW, any chance on including pass-through patches? Do you want me
> > > > to re-diff them?
> > >
> > > Hmm, I thought I've merged them in already, but obviously I did
> > > not. Please resend them (rediffed if possible). Thanks.
> >
> > I meant reconnect patches that Peter sent in his last mail, sorry for
> > the confusion.
>
> I don't think I'll apply those, sorry. We really should try to go the
> driver-model way and not invent our own ways how to restore devices
> hierarchically.

Reconnect patches are merely an extension of serio_rescan mechanism - the
only difference is that reconnect tries to keep the same input device if
the hardware didn't change. It does not care about any hierarchy, it just
a way for someone to try to re-initialize driver (probably the driver
itself). I for example never suspend, but my docking station resets the
touch pad back to relative mode. With reconnect it is possible to dock
and undock with X and GPM running and it will not screw your input
devices (rescan would create brand new input devices while X and GPM still
use old ones).

The pass-through support of all things implements device hierarchy in non
driver-model way and you just included it. The entire input subsystem is not
based on the driver model at the moment.. Are there plans to change it in 2.6
timeframe? If not for 2.6 then I would ask you to reconsider, reconnect will
make life of users much easier. If you have something in works could I have a
peek so I could probably adjust my patches.

BTW, is it possible with current driver model to reinitialize an arbitrary
device, not entire bus?

Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/