Re: [PATCH] autofs4 deadlock during expire - kernel 2.6

From: Ian Kent
Date: Wed Sep 24 2003 - 09:56:23 EST


On Wed, 24 Sep 2003, Arjan van de Ven wrote:

> On Wed, Sep 24, 2003 at 09:38:16PM +0800, Ian Kent wrote:
> > > interruptible_sleep_on ?
> > >
> >
> > OK so maybe I should have suggestions instead of comments.
>
> instead of interruptible_sleep_on(), it looks like you really want
> to use completions for this code..
> see kernel/workqueue.c for how those are used
>

I did try that but thinking again ...

The actual expire really needs to be interrutible.
I didn't like the idea that the additional waiters would be
uninterruptible but perhaps I have no choice.

Given that do you think that using an interruptible_sleep_on for the
expire and a completion for the additional waiters could give an
acceptable solution?

--

,-._|\ Ian Kent
/ \ Perth, Western Australia
*_.--._/ E-mail: raven@xxxxxxxxxx
v Web: http://themaw.net/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/