Re: [CHECKER] 32 Memory Leaks on Error Paths

[Alan Cox]

On Mer, 2003-09-24 at 05:13, Pete Zaitcev wrote: 
> -	spin_lock(&codec->ac97_lock);
> +	down(&unit->ac97_lock);
>  	/* XXX Do make use of dev->id */
> -	ymfpci_codec_ready(codec, 0, 0);

This breaks ac97 locking and should not be applied. The core ac97
code is called some times with interrupts disabled. That is unavoidable.

The only change that is relevant is the kfree

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/