Re: NS83820 2.6.0-test5 driver seems unstable on IA64

From: Matthew Wilcox
Date: Tue Sep 23 2003 - 19:16:36 EST


On Tue, Sep 23, 2003 at 04:37:44PM -0700, David S. Miller wrote:
> > > Not only sparc would be effected by this. Using {get,put}_unaligned()
> > > all over the networking would incur a penalty for many platforms, not
> > > just sparc.
> >
> > Really? I'd have thought that get/put_unaligned would be a simple
> > load/store for architectures which wish to implement it in that manner.
>
> Only on systems that have the "load upper/lower-unaligned"
> instructions. On others it's a memmove().

It is at the moment, but why should it be? Why can't it be implemented
as load-and-trap if that's the fastest way to do it?

(I can see this descending into get_unaligned_likely() and
get_aligned_unlikely() which i'd rather avoid ...)

--
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/