Re: [PATCH] 2.4 fix pci_generic_prep_mwi export breakage

[Jeff Garzik]

Bjorn Helgaas wrote:
> I think the recent change to pci.c to export pci_generic_prep_mwi() 
> is incorrect.
>
> pci_generic_prep_mwi() is only defined if !HAVE_ARCH_PCI_MWI,
> so it is wrong to export it.  In particular, it breaks on
> ia64, because we define HAVE_ARCH_PCI_MWI.
>
> It looks to me like the following patch should be applied.  This
> removes the export and in fact makes pci_generic_prep_mwi() static
> as it is in 2.5.


Looks OK to me.  Marcelo applied this already, right?

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/