Re: linux-2.6.0-test5/drivers/eisa verbose build failure

[Sam Ravnborg]

On Mon, Sep 15, 2003 at 03:31:51PM -0700, Adam J. Richter wrote:
> 	linux-2.6.0-test5/drivers/eisa fails to build if KBUILD_VERBOSE=1
> in the top level Linux Makefile (KBUILD_VERBOSE=1 causes the build
> process to show the actual commands that are being executed).
> 
> 	linux-2.6.0-test5/drivers/eisa/Makefile contains a change
> that tries to use the Linux KBUILD_VERBOSE system to control
> echoing of a command that contains some single quotes.  It looks
> like scripts/Makefile.lib contains some macros designed to put
> backslashes in front of single quotes as necessary to handle this
> case, but, somehow, this is not happening. 

Good analysis, thanks.
The following patch fixes it for me.
Would you mind trying this and report back.

	Sam

===== scripts/Makefile.lib 1.20 vs edited =====
--- 1.20/scripts/Makefile.lib	Sun Jun  8 20:06:56 2003
+++ edited/scripts/Makefile.lib	Sat Sep 20 09:11:28 2003
@@ -225,7 +225,7 @@
 
 # If quiet is set, only print short version of command
 
-cmd = @$(if $($(quiet)cmd_$(1)),echo '  $($(quiet)cmd_$(1))' &&) $(cmd_$(1))
+cmd = @$(if $($(quiet)cmd_$(1)),echo '  $(subst ','\'',$($(quiet)cmd_$(1)))' &&) $(cmd_$(1))
 
 #	$(call descend,<dir>,<target>)
 #	Recursively call a sub-make in <dir> with target <target> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/