Re: IA32 - 27 New warnings

From: Arnd Bergmann
Date: Thu Sep 18 2003 - 08:49:17 EST


John Cherry wrote:

> drivers/char/applicom.c:67: warning: `applicom_pci_tbl' defined but not used
> drivers/char/watchdog/alim1535_wdt.c:320: warning: `ali_pci_tbl' defined but not used
> drivers/media/video/zoran_card.c:148: warning: `zr36067_pci_tbl' defined but not used
> drivers/net/acenic.c:135: warning: `acenic_pci_tbl' defined but not used
> drivers/net/dgrs.c:123: warning: `dgrs_pci_tbl' defined but not used
> drivers/net/hp100.c:287: warning: `hp100_pci_tbl' defined but not used
> drivers/net/skfp/skfddi.c:185: warning: `skfddi_pci_tbl' defined but not used
> drivers/scsi/aha152x.c:397: warning: `id_table' defined but not used
> drivers/scsi/dtc.c:187: warning: `dtc_setup' defined but not used
> drivers/scsi/g_NCR5380.c:925: warning: `id_table' defined but not used
> drivers/scsi/gdth.c:868: warning: `gdthtable' defined but not used
> drivers/usb/class/usb-midi.h:150: warning: `usb_midi_ids' defined but not used
> sound/oss/ad1848.c:2967: warning: `id_table' defined but not used
> sound/oss/cmpci.c:2865: warning: `cmpci_pci_tbl' defined but not used

Does this patch help?

Arnd <><

===== include/linux/module.h 1.68 vs edited =====
--- 1.68/include/linux/module.h Fri Jul 4 00:00:09 2003
+++ edited/include/linux/module.h Thu Sep 18 15:26:23 2003
@@ -59,12 +59,12 @@
#define ___module_cat(a,b) __mod_ ## a ## b
#define __module_cat(a,b) ___module_cat(a,b)
#define __MODULE_INFO(tag, name, info) \
-static const char __module_cat(name,__LINE__)[] \
- __attribute__((section(".modinfo"),unused)) = __stringify(tag) "=" info
+static const char __module_cat(name,__LINE__)[] __attribute_used__ \
+ __attribute__((section(".modinfo"))) = __stringify(tag) "=" info

#define MODULE_GENERIC_TABLE(gtype,name) \
extern const struct gtype##_id __mod_##gtype##_table \
- __attribute__ ((unused, alias(__stringify(name))))
+ __attribute__ ((alias(__stringify(name))))

#define THIS_MODULE (&__this_module)

@@ -142,7 +142,8 @@
#define __CRC_SYMBOL(sym, sec) \
extern void *__crc_##sym __attribute__((weak)); \
static const unsigned long __kcrctab_##sym \
- __attribute__((section("__kcrctab" sec), unused)) \
+ __attribute_used__ \
+ __attribute__((section("__kcrctab" sec))) \
= (unsigned long) &__crc_##sym;
#else
#define __CRC_SYMBOL(sym, sec)
@@ -155,7 +156,8 @@
__attribute__((section("__ksymtab_strings"))) \
= MODULE_SYMBOL_PREFIX #sym; \
static const struct kernel_symbol __ksymtab_##sym \
- __attribute__((section("__ksymtab" sec), unused)) \
+ __attribute_used__ \
+ __attribute__((section("__ksymtab" sec))) \
= { (unsigned long)&sym, __kstrtab_##sym }

#define EXPORT_SYMBOL(sym) \
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/