Re: [PATCH] config BLK_DEV_IDE_TCQ_DEPTH - text and real life don't match

From: Jens Axboe
Date: Tue Sep 16 2003 - 04:28:10 EST


On Tue, Sep 16 2003, Jesper Juhl wrote:
>
> In drivers/ide/Kconfig you find the following help text for
> BLK_DEV_IDE_TCQ_DEPTH
>
> "You probably just want the default of 32 here. If you enter an invalid
> number, the default value will be used."
>
> But the default is /not/ 32, the default is 8. The patch bellow changes
> the default to match the help text... An alternative is of course to
> change the text to match the current default of 8, but I opted for
> changing the default in this patch.
>
>
> Kind regards,
>
> Jesper Juhl <jju@xxxxxx>
>
>
>
> diff -u linux-2.6.0-test5-orig/drivers/ide/Kconfig linux-2.6.0-test5/drivers/ide/Kconfig
> --- linux-2.6.0-test5-orig/drivers/ide/Kconfig 2003-09-08 21:50:03.000000000 +0200
> +++ linux-2.6.0-test5/drivers/ide/Kconfig 2003-09-16 00:30:20.000000000 +0200
> @@ -471,7 +471,7 @@
> config BLK_DEV_IDE_TCQ_DEPTH
> int "Default queue depth"
> depends on BLK_DEV_IDE_TCQ
> - default "8"
> + default "32"
> help
> Maximum size of commands to enable per-drive. Any value between 1
> and 32 is valid, with 32 being the maxium that the hardware supports.

Yes that is fine, thanks.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/