Re: Buggy PCI drivers - do not mark pci_device_id as discardable data
From: Greg KH
Date: Tue Sep 09 2003 - 23:25:18 EST
On Tue, Sep 09, 2003 at 06:12:48PM -0500, Matt Domsch wrote:
> > > agp_serverworks_probe() is marked __init. Thus the static lookup
> > Ah, Russell just got a patch for this into the tree today.
>
> Thanks Russell. However, I believe your patch only fixes the
> pci_device_id tables marked __initdata, not the probe functions (or
> anything they call) being marked __init, which is what Anatoly tripped up.
>
> At least these have probe functions marked __init in -test5.
These either need to be marked __devinit and make "new_id" dependant on
CONFIG_HOTPLUG, or we need to remove the __init marker on these
functions.
Any throughts about which?
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/