Re: [ACPI] Re: [PATCH] Next round of ACPI IRQ fixes (VIA ACPI fixed)
From: Jeff Garzik
Date: Fri Sep 05 2003 - 17:31:21 EST
Andrew de Quincey wrote:
On Friday 05 Sep 2003 10:35 pm, Jeff Garzik wrote:
This is why we _really_ need you to split up your patches. Multiple
split-up patches, one per email, is preferred. Don't worry about
sending us too much email: we like it like that.
If/when I split it up, is it acceptable to number the patches to give the
order they have to be applied in?
Absolutely. It's quite common for me to receive a series of emails, all
patches, where each successive patch has a dependency on the preceding
one. Linus just applies a patch series from Al Viro today which was
presented as
[PATCH] large dev_t - second series (1/15)
[PATCH] large dev_t - second series (2/15)
...
[PATCH] large dev_t - second series (15/15)
Many of us have patch-applying scripts, which can apply an entire mbox
full of patches. The email subject lines, the patch, and any text you
wrote in the email are all commited to the BitKeeper repository as a
single changeset.
As an aside, I know at least part of the VIA irq routing stuff still
needs fixing. For some on-board VIA southbridge devices, irq routing is
accomplished by writing the PCI_INTERRUPT_xxx values to PCI config
registers of the target device; for others, the normal pirq PCI config
registers on the southbridge are used. Alan's new irq stuff in 2.4.x
IMO should be merged into 2.6.x soonish, as Alan's work makes a big step
towards making it possible to fix some of the harder-to-fix irq routing
problems.
Is this still an issue when using ACPI? Surely it should insulate the OS from
this chipset-specific stuff?
Correct, proper ACPI tables on VIA will avoid this problem.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/