Re: [PATCH 2] Little fixes to previous futex patch

[Jamie Lokier]

Hugh Dickins wrote:
> You're right, the condition on clearing is fine.  It's the (lack of
> condition on) setting that's over-enthusiastic, should be saying:
> 
> 	if (start - vma->vm_start != (pgoff - vma->vm_pgoff) << PAGE_SHIFT)
> 		vma->vm_flags |= VM_NONLINEAR;

I hadn't thought of that.

I wonder if it's useful, though.  The only time it's likely to not set
the flag with it not already set, in real use, is when other VM code
calls remap_file_pages() with the whole vma.  But then the flag is
cleared by the next line.

So it's correct and nice, but I'm not sure it adds anything practical.

-- Jamie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/