Re: [PATCH] ikconfig - resolve rebuild permissions

From: Sam Ravnborg
Date: Thu Sep 04 2003 - 14:15:24 EST


On Thu, Sep 04, 2003 at 11:31:33AM -0700, Stephen Hemminger wrote:
> This patch fixes it by removing the configs.o file when
> needed.

A better approach would be to remove the need for compile.h from
configs.c. See attached patch for the makefile change.
It just took the relevant part from mk_compile and
used it in the Makefile.
Example only - I expect Randy to integrate it properly.

But what you see is also a more fundamental problem.
Should we allow the kernel to be build by two distinct users -
in this case a normal user and root.

We could check for this early, and stop. But it would require
too many changes in the top-level Makefile for my taste.

Sam

===== kernel/Makefile 1.33 vs edited =====
--- 1.33/kernel/Makefile Mon Sep 1 01:13:58 2003
+++ edited/kernel/Makefile Thu Sep 4 21:05:29 2003
@@ -19,6 +19,7 @@
obj-$(CONFIG_BSD_PROCESS_ACCT) += acct.o
obj-$(CONFIG_COMPAT) += compat.o
obj-$(CONFIG_IKCONFIG) += configs.o
+CFLAGS_configs.o = -DLINUX_COMPILER="$(shell $(CC) -v 2>&1 | tail -n 1)"

ifneq ($(CONFIG_IA64),y)
# According to Alan Modra <alan@xxxxxxxxxxxxxxxx>, the -fno-omit-frame-pointer is
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/