Re: [PATCH] Alternate futex non-page-pinning and COW fix

From: Linus Torvalds
Date: Thu Sep 04 2003 - 03:30:42 EST



On Thu, 4 Sep 2003, Rusty Russell wrote:
>
> However, Jamie's futex code will see !VM_SHARED on the mapping, and
> compare futexes by mm + uaddr (rather than inode + file offset), so
> this is NOT the case. Using VM_MAYSHARE instead would make the
> MAP_SHARED readonly case work as above, though.

But that is WORSE!

Now MAP_SHARED works, but MAP_PRIVATE does not. That's still the same bug,
but now it' san inconsistent bug!

I'd rather have a consistent bug than one that makes no sense.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/