Re: [BUG] mtime&ctime updated when it should not

From: Jan Kara
Date: Tue Sep 02 2003 - 12:09:20 EST


> Jan Kara <jack@xxxxxxx> wrote:
> >
> > > Isn't this sufficient?
> > I think it is not (I tried exactly the same patch but it didn't work)
> > - the problem is that vmtruncate() is called when prepare_write() fails
> > and this function also updates mtime and ctime.
>
> Oh OK.
>
> So we would need to change each filesystem's ->truncate to not update the
> inode times, then move the timestamp updating up into vmtruncate().
That is one solution. The other (less intrusive) is to just store old
time stamps and restore times when you find out that write failed.
I'll have a look how much work would be your solution..

Honza
--
Jan Kara <jack@xxxxxxx>
SuSE CR Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/