Re: 2.6.0-test4-mm3

[Martin Schlemmer]

On Fri, 2003-08-29 at 17:53, Valdis.Kletnieks@xxxxxx wrote:
> On Fri, 29 Aug 2003 16:55:47 +0200, Martin Schlemmer said:
> 
> > Cannot think of one that is known.  An quick solution
> > your (and not RH) side, might be something like below.
> 
> What about something like this instead?  I tested it with the module-init-tools
> and stock RH9 depmods...
> 
> Only complain if the depmod actually fails:
> 
> --- Makefile.hold	2003-08-27 01:52:20.000000000 -0400
> +++ Makefile	2003-08-29 11:52:15.542286300 -0400
> @@ -209,7 +209,7 @@
>  RPM 		:= $(shell if [ -x "/usr/bin/rpmbuild" ]; then echo rpmbuild; \
>  		    	else echo rpm; fi)
>  GENKSYMS	= scripts/genksyms/genksyms
> -DEPMOD		= /sbin/depmod
> +DEPMOD		= /sbin/depmod.old
>  KALLSYMS	= scripts/kallsyms
>  PERL		= perl
>  CHECK		= sparse
> @@ -612,7 +612,14 @@
>  endif
>  .PHONY: _modinst_post
>  _modinst_post: _modinst_
> -	if [ -r System.map ]; then $(DEPMOD) -ae -F System.map $(depmod_opts) $(KERNELRELEASE); fi
> +	@if [ -r System.map ]; then \
> +		if ! $(DEPMOD) -ae -F System.map $(depmod_opts) $(KERNELRELEASE)   ; then \
> +			echo "*** Depmod failed!!!"; \
> +			echo "*** You may need to install a current version of module-init-tools"; \
> +			echo "*** See http://www.codemonkey.org.uk/post-halloween-2.5.txt";; \
> +			exit 1; \
> +	 	fi \
> +	fi
>  
>  else # CONFIG_MODULES

Hmm, this will only work with RH based systems (not using here).  I
think the best way is how Andrew did it to just warn if depmod fails.
You may agree to disagree if need be :)


Regards,

-- 

Martin Schlemmer

Attachment: signature.asc
Description: This is a digitally signed message part