Re: [PATCH] 2.6.0-test4 stallion serial driver cleanup

[Zwane Mwaikambo]

On Wed, 27 Aug 2003, Peter Chubb wrote:

> +		/* FIXME -- pass in a valid device id */
>  		if (request_irq(irq, stl_intr, SA_SHIRQ, name, NULL) != 0) {
>  			printk("STALLION: failed to register interrupt "
>  				"routine for %s irq=%d\n", name, irq);

You can't do SA_SHIRQ and none unique dev_id, please really do fix that.

Thanks,
	Zwane

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/