Re: [PATCH 1/4] Net device error logging, revised

[Greg KH]

On Mon, Aug 25, 2003 at 02:31:19PM -0700, Jim Keniston wrote:
> +int __netdev_printk(const char *sevlevel, const struct net_device *netdev,
> +	int msglevel, const char *format, ...)
> +{
> +	if (!netdev || !format) {
> +		return -EINVAL;
> +	}
> +	if (msglevel == NETIF_MSG_ALL || (netdev->msg_enable & msglevel)) {
> +		char msg[512];

512 bytes on the stack?  Any way to prevent this from happening?  With
the push to make the stack even smaller in 2.7, people will not like
this.

thanks,

greg k-h

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/