Re: [BK PATCH] One strdup() to rule them all

[Dan Aloni]

On Mon, Aug 25, 2003 at 01:05:30PM -0400, Jeff Garzik wrote:
> On Mon, Aug 25, 2003 at 12:25:32PM -0400, Jakub Jelinek wrote:
> > On Mon, Aug 25, 2003 at 07:14:35PM +0300, Dan Aloni wrote:
> > > diff -Nru a/lib/string.c b/lib/string.c
> > > --- a/lib/string.c	Mon Aug 25 19:03:26 2003
> > > +++ b/lib/string.c	Mon Aug 25 19:03:26 2003
> > > @@ -582,3 +582,19 @@
> > >  }
> > >  
> > >  #endif
> > > +
> > > +/**
> > > + * strdup - Allocate a copy of a string.
> > > + * @s: The string to copy. Must not be NULL.
> > > + *
> > > + * returns the address of the allocation, or NULL on
> > > + * error. 
> > > + */
> > > +char *strdup(const char *s)
> > > +{
> > > +	char *rv = kmalloc(strlen(s)+1, GFP_KERNEL);
> > > +	if (rv)
> > > +		strcpy(rv, s);
> > > +	return rv;
> > > +}
> > > +EXPORT_SYMBOL(strdup);
> > 
> > Better save strlen(s)+1 in a local size_t variable and use memcpy instead
> > of strcpy.
> 
> Yep.  When Rusty did his strdup cleanup, he followed my suggestion and
> did just that.
> 
> Unfortunately Linus doesn't like the strdup cleanup, so I don't see this
> patch going in either :)

Perhaps Linus would like to keep strdup()'s scattered across the kernel, 
so their combined power would not be exploited by evil <insert silly LotR 
humor here>. :) I'll end this thread here.

-- 
Dan Aloni
da-x@xxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/