Re: [PATCH 2.6] Synaptics: support reconnect keeping the same inputdevice

[Peter Berg Larsen]

On Sat, 23 Aug 2003, Dmitry Torokhov wrote:

> Here is the update to the Synaptics touchpad driver. It is supposed to go
> on top of patches form Peter Osterlund site:

> +	if (SYN_CAP_MULTI_BUTTON_NO(priv->ext_cap)) {
>  		switch (SYN_CAP_MULTI_BUTTON_NO(priv->ext_cap) & ~0x01) {
>  		default:
>  			printk(KERN_ERR "This touchpad reports more than 8 multi-buttons, don't know how to handle.\n");
>  		case 8:
...
>  		case 6:
>  		case 4:
>  		case 2:
>  		}

I think a break is needed after the default case as the documentation says
"If nExtBtm is greater than 8 ... nExtbtm should be considered to be
invalid and treated as zero."

Peter


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/