Re: [PM] Patrick: which part of "maintainer" and "peer review" needsexplaining to you?

[Patrick Mochel]

> > >  static int __init resume_setup(char *str)
> > >  {
> > > -	strncpy( resume_file, str, 255 );
> > > +	if (strlen(str))
> > > +		strncpy(resume_file, str, 255);
> > >  	return 1;
> > >  }
> > > 
> > > Why are you obfuscating the code?
> > 
> > Eh? First, why would you want to copy a NULL string? 
> 
> How is strlen(NULL) better than strncpy(_, NULL, _)?

Well, it will tell you whether or not you copied anything. Which, like I 
mentioned before, can be used to determine whether or not the user really 
wants to resume or not, in lieu of a superfluous command line parameter 
("noresume"). 


	Pat

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/