Re: [PATCH] bio.c: reduce verbosity at boot
From: Lou Langholtz
Date: Thu Aug 21 2003 - 11:56:45 EST
Jeff Garzik wrote:
Matthew Wilcox wrote:
Linux is really far too verbose at boot time. I don't think these
messages
add anything to either the end user experience or debug ability.
Index: fs/bio.c
===================================================================
RCS file: /var/cvs/linux-2.6/fs/bio.c,v
retrieving revision 1.2
diff -u -p -r1.2 bio.c
--- fs/bio.c 29 Jul 2003 17:25:49 -0000 1.2
+++ fs/bio.c 21 Aug 2003 14:58:40 -0000
@@ -793,10 +793,6 @@ static void __init biovec_init_pools(voi
mempool_free_slab, bp->slab);
if (!bp->pool)
panic("biovec: can't init mempool\n");
-
- printk("biovec pool[%d]: %3d bvecs: %3d entries (%d bytes)\n",
- i, bp->nr_vecs, pool_entries,
- size);
. . . removing the messages outright might not serve the best
interests the developer. Since even KERN_DEBUG still spams dmesg, in
these situations I usually change these type of messages to be
conditionally printed iff a debug macro is enabled.
How about using KERN_DEBUG and augmenting the dmesg store so that the
level that is saved is configurable? Even compile time configurable
seems reasonable to start. But axeing out even the possibility of boot
time info seems bad to me.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/