Re: Input issues - key down with no key up

From: Neil Brown
Date: Tue Aug 19 2003 - 06:44:52 EST


On Monday August 18, vojtech@xxxxxxx wrote:
>
> How about this patch? It tries to be a bit clever, but hopefully not too
> much ...
>

Uhmm.. mixed.

It behaved REALLY strangly until I fixed these typoes:

> + mod_timer(&atkbd->timer,
> + (test_bit(atkbd->keycode[code], &atkbd->dev.key)
> + ? HZ/30 : HZ/4) + HZ/100);

should be

> + mod_timer(&atkbd->timer, jiffies +
> + (test_bit(atkbd->keycode[code], atkbd->dev.key)
> + ? HZ/30 : HZ/4) + HZ/100);

Then it sort-of worked - my problem keys gave nice up/down
transitions.

However the hardware autorepeat and the software autorepeat seemed to
interfere with each other and auto-repeat was rather erratic.

More of a problem was that control and shift would auto-repeat, and
would often appear to be "up" when I was holding them "down", so
control-X keys strokes were not reliable.

Thanks,
NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/