Re: [PATCH] Ratelimit SO_BSDCOMPAT warnings

[David S. Miller]

On Mon, 18 Aug 2003 18:15:40 -0400
Valdis.Kletnieks@xxxxxx wrote:

> On Mon, 18 Aug 2003 15:06:05 PDT, Phil Oester said:
> >  static void sock_warn_obsolete_bsdism(const char *name)
> >  {
> > -       printk(KERN_WARNING "process `%s' is using obsolete "
> > -              "%s SO_BSDCOMPAT\n", current->comm, name);
> > +       static int warned;
> > +
> > +       if (!warned) {
> > +               warned = 1;
> 
> Umm.. am I dense, or does this only warn once for *the first program*
> to do it after the system boots?  And you don't get another warning about
> any OTHER programs until you reboot in a few weeks (possibly)?

Yes, this patch does suck hard.

I see no reason to apply this, just fix your apps and the
warning will stop.  There's only a handful of programs
that trigger this at all.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/