Re: [PATCH] Re: [PATCH] scsi.h uses "u8" which isn't defined.

From: Jeff Garzik
Date: Mon Aug 18 2003 - 10:39:53 EST


On Mon, Aug 18, 2003 at 08:21:45AM -0700, Linus Torvalds wrote:
>
> On Mon, 18 Aug 2003 Andries.Brouwer@xxxxxx wrote:
> >
> > I see that Linus already applied this, but I am quite unhappy with
> > these changes. Entirely needlessly user space software is broken.
>
> If it's supposed to be exported to user space, it _still_ must not use
> "u_char", since that isn't namespace-clean.
>
> If it needs exporting, it must use "__u8".

Maybe I am biased, but I actually prefer to use the C99 size-specific
types, when code will be used outside the kernel tree... even if that
userland code is entirely Linux-kernel-specific. I try to avoid "__u<size>"
since it's typically a gcc-specific type.

C99 gave us the tools, we should use them :)

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/