Re: [RFC][PATCH] Make cryptoapi non-optional?

From: Andreas Dilger
Date: Mon Aug 18 2003 - 01:48:37 EST


On Aug 15, 2003 23:38 -0500, Matt Mackall wrote:
> a) extract_entropy (pool->lock)
>
> For nitpickers, there remains a vanishingly small possibility that
> two readers could get identical results from the pool by hitting a
> window immediately after reseeding, after accounting, _and_ after
> feedback mixing.

It wasn't even vanishingly small... We had a problem in our code where
two readers got the same 64-bit value calling get_random_bytes(), and
we were depending on this 64-bit value being unique. This problem was
fixed by putting a spinlock around the call to get_random_bytes().

Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/