Re: [PATCH] 5/8 Backport recent 2.6 IDE updates to 2.4.x

From: Willy TARREAU
Date: Sun Aug 17 2003 - 02:26:35 EST


On Sun, Aug 17, 2003 at 01:13:32AM -0600, Erik Andersen wrote:
> On Sun Aug 17, 2003 at 08:59:54AM +0200, Willy Tarreau wrote:
> > On Sun, Aug 17, 2003 at 12:13:39AM -0600, Erik Andersen wrote:
> >
> > > + printk(KERN_INFO "%s: Host Protected Area detected.\n"
> > > + "\tcurrent capacity is %ld sectors (%ld MB)\n"
> > > + "\tnative capacity is %ld sectors (%ld MB)\n",
> > > + drive->name,
> > > + capacity, (capacity - capacity/625 + 974)/1950,
> > > + set_max, (set_max - set_max/625 + 974)/1950);
> >
> > Just a question : why didn't you use your sectors_to_MB() function here, to
> > make this replace the unreadable hack above ?
>
> Mainly because sectors_to_MB() didn't exist yet when I wrote this
> part. :-) This was later fixed by Andries Brouwer. which shows up
> in patch #7,

OK thanks. I was looking exactly for this before this mail to you but didn't
notice it was the same part of code which is changed in patch 7.
It's OK now :-)

Cheers,
Willy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/