Re: [PATCH] do_wp_page: BUG on invalid pfn

[Ed L Cashin]

Russell King <rmk@xxxxxxxxxxxxxxxx> writes:

> On Fri, Aug 15, 2003 at 05:15:45PM -0400, Ed L Cashin wrote:
>> +		dump_stack();
>> +		BUG();
>
> Is there much point to both dump_stack and BUG() - BUG is supposed to
> provide a calltrace, which dump_stack also does.  Do we really need two
> copies?

On i386 WARN_ON calls dump_stack, but BUG just prints some minimal
helpful info on the console, like this:

------------[ cut here ]------------
kernel BUG at kernel/any.c:36!
invalid operand: 0000 [#1]


-- 
--Ed L Cashin            |   PGP public key:
  ecashin@xxxxxxx        |   http://noserose.net/e/pgp/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/