Re: [PATCH][2.4.22-rc2] Disable APIC on reboot.

From: Marc-Christian Petersen
Date: Fri Aug 15 2003 - 14:25:59 EST


On Tuesday 12 August 2003 01:33, Mikael Pettersson wrote:

Hi Mikael,

> disable_local_APIC() now checks if detect_init_APIC() enabled the
> local APIC via the APIC_BASE MSR, and if so it now disables APIC_BASE.
> Previously we would leave APIC_BASE enabled, and that made some
> BIOSen unhappy.
> The SMP reboot code calls disable_local_APIC(). On SMP HW there is
> no change since detect_init_APIC() isn't called and APIC_BASE isn't
> enabled by us. An SMP kernel on UP HW behaves just like an UP_APIC
> kernel, so it disables APIC_BASE if we enabled it at boot.
> The UP_APIC disable-before-suspend code is simplified since the existing
> code to disable APIC_BASE is moved into disable_local_APIC().
> (Felix Kühling originally reported the BIOS reboot problem. This is a
> fixed-up version of his preliminary patch.)

please correct me if I say something really stupid now but shouldn't the APIC
be disabled only during reboot time and enabled again at a new boot?

my experience with this patch is, after a reboot he APIC isn't enabled again
until I power off my machine.

ciao, Marc

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/